Rename command logging services #6575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -81,7 +81,7 @@ First configure a listener for console exception events in the service container | |||
|
|
|||
| # app/config/services.yml | |||
| services: | |||
| kernel.listener.command_dispatch: | |||
There was a problem hiding this comment.
Unrelated to this pull request, but shouldn't these services be called app.* instead of kernel.* ?
There was a problem hiding this comment.
You are right, that makes more sense. Do you want me to update the PR?
There was a problem hiding this comment.
That would be good. There is no need to do this in another PR.
There was a problem hiding this comment.
@javiereguiluz @xabbuh updated.
|
@sroze 👍 nice! Thank you. |
xabbuh
added a commit
that referenced
this pull request
May 19, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6575). Discussion ---------- Rename command logging services | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 3.0 | Fixed tickets | ø This PR updates the name of the services used for the two listeners. The main reason is that if the developer simply copy/paste the two services' definition, it won't work as expected as they have the same name. The first one will be replaced. Commits ------- bbae797 Rename command logging services
|
Thank you @sroze! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the name of the services used for the two listeners. The main reason is that if the developer simply copy/paste the two services' definition, it won't work as expected as they have the same name. The first one will be replaced.