6338 use csrfManager instead of csrfProvider #6586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoek09
commented
May 21, 2016
snoek09
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.7 |
| Fixed tickets | #6338 |
|
I don't think we should include the complete setup. Instead use |
| $session = new Session(); | ||
|
|
||
| $csrfGenerator = new UriSafeTokenGenerator(); | ||
| $csrfStorage = new SessionTokenStorage($session); |
There was a problem hiding this comment.
I wonder if it wasn't better to use the NativeSessionTokenStorage to not depend on the HttpFoundation component here.
Never mind, we already have this above.
|
👍 Thanks! |
|
Thank you @snoek09. |
xabbuh
added a commit
that referenced
this pull request
May 21, 2016
This PR was squashed before being merged into the 2.7 branch (closes #6586). Discussion ---------- 6338 use csrfManager instead of csrfProvider | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.7 | Fixed tickets | #6338 Commits ------- 500dce5 6338 use csrfManager instead of csrfProvider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.