Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note about "encoding vs. hashing" passwords #6595

Merged
merged 1 commit into from
May 21, 2016

Conversation

javiereguiluz
Copy link
Member

It's impossible to replace "encode" by "hash" in Symfony code/docs ... but we could add a short note about this to fix #5688.

@wouterj
Copy link
Member

wouterj commented May 21, 2016

👍 (although I'm not really sure if I like making book articles more verbose with such details)

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

👍

@javiereguiluz
Copy link
Member Author

(@wouterj I thought about a better location but I couldn't find any ... in any case, I expect the security doc to change a lot soon)

@wouterj
Copy link
Member

wouterj commented May 21, 2016

Thanks Javier.

@wouterj wouterj merged commit a5cb692 into symfony:2.3 May 21, 2016
wouterj added a commit that referenced this pull request May 21, 2016
…ereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Added a note about "encoding vs. hashing" passwords

It's impossible to replace "encode" by "hash" in Symfony code/docs ... but we could add a short note about this to fix #5688.

Commits
-------

a5cb692 Added a note about "encoding vs. hashing" passwords
@javiereguiluz javiereguiluz deleted the fix_5688 branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants