Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed query_builder option #6596

Merged
merged 1 commit into from
May 21, 2016
Merged

Conversation

HeahDude
Copy link
Contributor

doc fix: 2.3+

ref #6594 (comment)

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

👍

@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

You could also update the text to something like this:

The value of this option can either be a ``QueryBuilder`` object, a Closure or ``null``.

@HeahDude
Copy link
Contributor Author

Ok then #6594 will need a rebase.

@HeahDude HeahDude force-pushed the fix/query_builder-option branch from b394ea4 to 45f586b Compare May 21, 2016 14:48
@HeahDude
Copy link
Contributor Author

Fixed

@wouterj
Copy link
Member

wouterj commented May 21, 2016

Thanks Jules! I'm sorry for -1'ing you in #6594, you were 100% correct.

@wouterj wouterj merged commit 45f586b into symfony:2.3 May 21, 2016
wouterj added a commit that referenced this pull request May 21, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

Fixed query_builder option

doc fix: 2.3+

ref #6594 (comment)

Commits
-------

45f586b Fixed query_builder option
@HeahDude HeahDude deleted the fix/query_builder-option branch May 21, 2016 14:59
wouterj added a commit that referenced this pull request May 21, 2016
@wouterj
Copy link
Member

wouterj commented May 21, 2016

Oh btw, I just made a minor improvement in 31de26f

@HeahDude
Copy link
Contributor Author

@wouterj 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants