[Process] Add explanation on how to make the Process survive a response #7159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes symfony#7151 It confuses user that could be tempted to use the Asynchronous Process feature to achieve long running task after the Response is sent. The result is the following : from no code execution (if you send a Response really fast) to partial code execution
tristanbes
changed the title
|
|
||
| If you want your process to survive the request/response cycle, you could take | ||
| advantage of the ``kernel.terminate`` event, and run your command **synchronuously** | ||
| inside this event. Be aware that ``kernel.terminate`` is called only if you run ``PHP-FPM``. |
There was a problem hiding this comment.
Beware also that if you do that, the said php process won't available to serve any new request until the subprocess is finished, which means you can block your FPM pool quickly if you're not careful enough. That's why it generally way better to not do any fancy thing even after the request is sent but prefer using a job queue.
There was a problem hiding this comment.
Do you want me to add a note to include this remark ?
There was a problem hiding this comment.
Yes, I think that's an important note that should be added inside a caution block.
|
any updates I can do for you to merge this ? |
HeahDude
approved these changes
Mar 4, 2017
|
|
||
| .. caution:: | ||
|
|
||
| Beware also that if you do that, the said php process won't available to serve |
| Beware also that if you do that, the said php process won't available to serve | ||
| any new request until the subprocess is finished, which means you can block your | ||
| FPM pool quickly if you're not careful enough. | ||
| That's why it generally way better to not do any fancy thing even after the request is sent |
|
Thank you @tristanbes. |
xabbuh
added a commit
that referenced
this pull request
Mar 13, 2017
…ive a response (tristanbes, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- [Process] Add explanation on how to make the Process survive a response Fixes #7151 It clarifies the situation for users that could be tempted to use the asynchronous `Process` feature to achieve long running task after the Response is sent which won't work. It goes from no code execution (if you send a Response really fast) to partial code execution. Commits ------- cdf248c add a caution block about php-fpm pool 020f1b7 Fixed some syntax issues 64de236 Add explanation how to make the Process survive a response
xabbuh
added a commit
that referenced
this pull request
Mar 13, 2017
|
My pleasure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7151
It clarifies the situation for users that could be tempted to use the asynchronous
Processfeature to achieve long running task after the Response is sent which won't work.It goes from no code execution (if you send a Response really fast) to partial code execution.