Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Updated direct submit article #7707

Merged
merged 3 commits into from
Apr 8, 2017

Conversation

HeahDude
Copy link
Contributor

There have been many issues in the past on symfony repo about this (ref symfony/symfony#19788), let's make it explicit in the docs.

This article is linked at the very beginning of the Form component introduction.

within the form object. Otherwise, the missing fields will be set to ``null``.

.. caution::

When the second parameter ``$clearMissing`` is ``false``, like with "PATCH"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] with the "PATCH" method [...]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@xabbuh
Copy link
Member

xabbuh commented Apr 8, 2017

Thank you Jules.

@xabbuh xabbuh merged commit 6e9bf0b into symfony:2.7 Apr 8, 2017
xabbuh added a commit that referenced this pull request Apr 8, 2017
…iluz)

This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Updated direct submit article

There have been many issues in the past on symfony repo about this (ref symfony/symfony#19788), let's make it explicit in the docs.

This article is linked at the very beginning of the Form component introduction.

Commits
-------

6e9bf0b fixup comment
8a47176 Let's break a long sentence into two shorter sentences
23e06a8 [Form] Updated direct submit article
xabbuh added a commit that referenced this pull request Apr 8, 2017
@HeahDude HeahDude deleted the fix/form-direct_submit branch April 8, 2017 11:21
xabbuh added a commit that referenced this pull request Apr 9, 2017
* 2.7: (48 commits)
  docs: choice constraints reference
  [#7707] minor tweak
  Fixed code block under "Custom Messages"
  [#7744] fix XSD locations
  Minor XML codes fixes
  [#7686] tweak the example code
  [#7663] update the PHP example code
  Update hostname_pattern.rst
  Add missing ";"
  Use HTTP instead of http
  Fixed indentation in security.rst
  Be consistent on service name
  Fix missing /
  Fix trusted hosts example regular expressions
  fixup comment
  Testing: Fix typo from #6427
  Update apache_router.rst
  Update fortrabbit.rst
  Fix some YAML codes
  Add missing trailing comma & Fix foreach code
  ...
xabbuh added a commit that referenced this pull request Apr 13, 2017
* 2.8: (48 commits)
  docs: choice constraints reference
  [#7707] minor tweak
  Fixed code block under "Custom Messages"
  [#7744] fix XSD locations
  Minor XML codes fixes
  [#7686] tweak the example code
  [#7663] update the PHP example code
  Update hostname_pattern.rst
  Add missing ";"
  Use HTTP instead of http
  Fixed indentation in security.rst
  Be consistent on service name
  Fix missing /
  Fix trusted hosts example regular expressions
  fixup comment
  Testing: Fix typo from #6427
  Update apache_router.rst
  Update fortrabbit.rst
  Fix some YAML codes
  Add missing trailing comma & Fix foreach code
  ...
xabbuh added a commit that referenced this pull request Apr 13, 2017
* 3.2: (60 commits)
  docs: choice constraints reference
  [#7707] minor tweak
  Fixed code block under "Custom Messages"
  [#7744] fix XSD locations
  Minor XML codes fixes
  [#7686] tweak the example code
  [#7663] update the PHP example code
  Update hostname_pattern.rst
  Add missing ";"
  Use HTTP instead of http
  Fixed indentation in security.rst
  Be consistent on service name
  Fix missing /
  typo fix
  Fix trusted hosts example regular expressions
  add reference built in listener for kernel.response event in >=3.1
  fixup comment
  Testing: Fix typo from #6427
  Update apache_router.rst
  Update fortrabbit.rst
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants