[2.8] [Form] Rename CollectionType options for entries #15025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,12 +52,12 @@ class ResizeFormListener implements EventSubscriberInterface | |||
| */ | |||
| private $deleteEmpty; | |||
|
|
|||
| public function __construct($type, array $options = array(), $allowAdd = false, $allowDelete = false, $deleteEmpty = false) | |||
| public function __construct($entryType, array $entryOptions = array(), $allowAdd = false, $allowDelete = false, $deleteEmpty = false) | |||
There was a problem hiding this comment.
Can you revert the variable renames in this method? They don't really make sense now IMO.
|
We need a few legacy tests using the old option names |
|
@wouterj We need to finish this one this week if we want to include it in 2.8. |
|
@fabpot I'm sorry for the delay. fixed all comments & added some legacy tests. Should be ready to merge now |
| @@ -791,7 +791,7 @@ public function testSubmitSingleExpandedRequiredEmptyNoChoices() | |||
| $this->assertTrue($form->isSynchronized()); | |||
| } | |||
|
|
|||
| public function testSubmitSingleExpandedRequiredFalse() | |||
| public function testSubmiCollectiontSingleExpandedRequiredFalse() | |||
There was a problem hiding this comment.
This change seems like a mistake, reverted it
|
I cannot relate any of the build failures to changes in this PR |
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Oct 11, 2015
… (WouterJ) This PR was merged into the 2.8 branch. Discussion ---------- [2.8] [Form] Rename CollectionType options for entries Description --- Replaces #13820 for the 2.8 branch. Original description: > `type` and `options` are extremely generic. Prefixing them with `entry_` makes it clear what they are configuring. > About the property deprecation it is the same story as #13717 and I don't know which direction you want me to go. I've tried to apply the comments in the previous PR, but got a bit lost in the normalizers/default closure stuff. I hope I did everything correctly, but please review :) PR Info Table --- | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #7831 | License | MIT | Doc PR | symfony/symfony-docs#5051 Commits ------- 942a237 Rename CollectionType options for entries
|
I'm using |
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 15, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #5051). Discussion ---------- Rename CollectionType entry options | Q | A | --- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#15025) | Applies to | 2.7+ | Fixed tickets | - Commits ------- 1b00278 Rename CollectionType entry options
craue
added a commit
to craue/CraueConfigBundle
that referenced
this pull request
Oct 20, 2015
…h Symfony >= 2.8 see symfony/symfony#15025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces #13820 for the 2.8 branch.
Original description:
I've tried to apply the comments in the previous PR, but got a bit lost in the normalizers/default closure stuff. I hope I did everything correctly, but please review :)
PR Info Table