[FrameworkBundle] Fix precedence of xdebug.file_link_format #15549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Should we also simplify the constructor of the Twig's Code extension? See https://github.com/symfony/symfony/blob/2.3/src/Symfony/Bridge/Twig/Extension/CodeExtension.php#L34 |
|
@javiereguiluz the bridge could be used without the FrameworkBundle |
|
|
||
| $container->setParameter('templating.helper.code.file_link_format', isset($links[$ide]) ? $links[$ide] : $ide); | ||
| $link = ini_get('xdebug.file_link_format') ?: get_cfg_var('xdebug.file_link_format') ?: $ide; | ||
| $container->setParameter('templating.helper.code.file_link_format', isset($links[$link]) ? $links[$link] : $link); |
There was a problem hiding this comment.
checking $links[$link] for values coming from XDebug config does not make sense IMO
nicolas-grekas
force-pushed
the
fix-file-link-prio
branch
from
339c3b6 to
adb5327
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 23, 2015
…t (nicolas-grekas) This PR was merged into the 2.3 branch. Discussion ---------- [FrameworkBundle] Fix precedence of xdebug.file_link_format | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#5625 See symfony/demo#148 (comment) Commits ------- adb5327 [FrameworkBundle] Fix precedence of xdebug.file_link_format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/demo#148 (comment)