-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifier] Add options to Telegram Bridge #49986
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nsbx
force-pushed
the
telegram-photo
branch
2 times, most recently
from
April 10, 2023 12:40
9021ed6
to
1bf2793
Compare
alamirault
reviewed
Apr 10, 2023
OskarStark
reviewed
Apr 11, 2023
OskarStark
reviewed
Apr 11, 2023
src/Symfony/Component/Notifier/Bridge/Telegram/Tests/TelegramTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 11, 2023
src/Symfony/Component/Notifier/Bridge/Telegram/Tests/TelegramTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 11, 2023
src/Symfony/Component/Notifier/Bridge/Telegram/Tests/TelegramTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Apr 11, 2023
src/Symfony/Component/Notifier/Bridge/Telegram/Tests/TelegramTransportTest.php
Show resolved
Hide resolved
OskarStark
requested changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
OskarStark
reviewed
Apr 13, 2023
OskarStark
force-pushed
the
telegram-photo
branch
from
April 13, 2023 07:33
c77c4e1
to
4ebb994
Compare
Thank you Nicolas. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2023
…document`, `audio`, `video`, `venue`, `photo`, `animation`, `sticker` & `contact` (igrizzli) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Notifier] [Telegram] Extend options for `location`, `document`, `audio`, `video`, `venue`, `photo`, `animation`, `sticker` & `contact` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Extends #49986 for sending local files as photo Add possibility to send point on map in notification. Commits ------- e223f8e [Notifier] [Telegram] Extend options for `location`, `document`, `audio`, `video`, `venue`, `photo`, `animation`, `sticker` & `contact`
symfony-splitter
pushed a commit
to symfony/notifier
that referenced
this pull request
Oct 10, 2023
…document`, `audio`, `video`, `venue`, `photo`, `animation`, `sticker` & `contact` (igrizzli) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Notifier] [Telegram] Extend options for `location`, `document`, `audio`, `video`, `venue`, `photo`, `animation`, `sticker` & `contact` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Extends symfony/symfony#49986 for sending local files as photo Add possibility to send point on map in notification. Commits ------- e223f8e798 [Notifier] [Telegram] Extend options for `location`, `document`, `audio`, `video`, `venue`, `photo`, `animation`, `sticker` & `contact`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord, Mastodon and other notifier have possibility to send photo.
Telegram can send photo too but not the bridge.
With this small change, this is now possible.