Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo ("a", not "an") #1

Closed
wants to merge 1 commit into from
Closed

fix typo ("a", not "an") #1

wants to merge 1 commit into from

Conversation

tacman
Copy link
Contributor

@tacman tacman commented Nov 10, 2024

No description provided.

@nicolas-grekas
Copy link
Member

This is a read-only subtree split isn't it?

@tacman
Copy link
Contributor Author

tacman commented Nov 10, 2024

probably. I often have trouble finding the source to make the change. Since that's an automated process, could you add a link to where it is in the monorepo? Since the main code, UX and documentation are separate repos, sometimes it's a bit of a challenge to figure out where to suggest a change or post an issue.

@Kocal
Copy link
Member

Kocal commented Nov 19, 2024

It is supposed to be read-only yes... 🤔

Gonna open a PR to automatically close PRs on symfony/ux-* repos

@tacman
Copy link
Contributor Author

tacman commented Nov 19, 2024

Can you automatically add a link to the ux repo? And maybe put it in the issue template?

@Kocal
Copy link
Member

Kocal commented Nov 19, 2024

Yes, I want to do something like that symfony/http-client#13 (comment)

@nicolas-grekas any hints? 🙏🏻 :)

EDIT: it's simply defined in https://github.com/symfony/symfony/tree/7.2/src/Symfony/Component/Asset/.github, gonna create a PR to UX soon

@Kocal
Copy link
Member

Kocal commented Nov 20, 2024

Opened symfony/ux#2395, this should fix the problem and makes UX packages splits read-only.

@tacman can you open your PR on symfony/ux instead please? Thanks 🙏🏻

@Kocal Kocal closed this Nov 20, 2024
Kocal added a commit to symfony/ux that referenced this pull request Nov 20, 2024
…tories (Kocal)

This PR was merged into the 2.x branch.

Discussion
----------

Add PR template and auto-close PR on subtree split repositories

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Issues        | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

<!--
Replace this notice by a description of your feature/bugfix.
This will help reviewers and should be a good start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - For new features, provide some code snippets to help understand usage.
 - Features and deprecations must be submitted against branch main.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
 - Never break backward compatibility (see https://symfony.com/bc).
-->

Taken from symfony/http-client@54118c6, because symfony/ux-google-map#1 and
#2340 (comment)

Commits
-------

89b735e Add PR template and auto-close PR on subtree split repositories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants