bug #561 [Autocomplete] Don't add WHERE IN criteria without params (n…

…orkunas) This PR was merged into the 2.x branch. Discussion ---------- [Autocomplete] Don't add WHERE IN criteria without params | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | Fix #549 | License | MIT Commits ------- d581ea7 [Autocomplete] Don't add WHERE IN criteria without params
symfony · Nov 28, 2022 · 4296071 · 4296071
2 parents 95f5011 + d581ea7
commit 4296071
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 5 deletions.
diff --git a/src/Autocomplete/src/Form/AutocompleteEntityTypeSubscriber.php b/src/Autocomplete/src/Form/AutocompleteEntityTypeSubscriber.php
@@ -73,11 +73,15 @@ public function preSubmit(FormEvent $event)
                     ++$idx;
                 }
 
-                $options['choices'] = $repository->createQueryBuilder('o')
-                    ->where(sprintf("o.$idField IN (%s)", implode(', ', array_keys($params))))
-                    ->setParameters(new ArrayCollection($params))
-                    ->getQuery()
-                    ->getResult();
+                $queryBuilder = $repository->createQueryBuilder('o');
+
+                if ($params) {
+                    $queryBuilder
+                        ->where(sprintf("o.$idField IN (%s)", implode(', ', array_keys($params))))
+                        ->setParameters(new ArrayCollection($params));
+                }
+
+                $options['choices'] = $queryBuilder->getQuery()->getResult();
             } else {
                 $options['choices'] = $repository->createQueryBuilder('o')
                     ->where("o.$idField = :id")

diff --git a/src/Autocomplete/tests/Functional/AutocompleteFormRenderingTest.php b/src/Autocomplete/tests/Functional/AutocompleteFormRenderingTest.php
@@ -93,4 +93,25 @@ public function testProperlyLoadsChoicesWithIdValueObjects()
             ->assertContains('Sugar')
         ;
     }
+
+    public function testMultipleDoesNotFailWithoutSelectedChoices()
+    {
+        $this->browser()
+            ->throwExceptions()
+            ->get('/test-form')
+            ->assertElementCount('#product_ingredients_autocomplete option', 0)
+            ->assertNotContains('Flour')
+            ->assertNotContains('Sugar')
+            ->post('/test-form', [
+                'body' => [
+                    'product' => [
+                        'ingredients' => [
+                            'autocomplete' => [],
+                        ],
+                    ],
+                ],
+            ])
+            ->assertElementCount('#product_ingredients_autocomplete option', 0)
+        ;
+    }
 }