[Translator] Mark classes from "Intl/*.php" as final and internal

symfony · Sep 26, 2024 · 4f3c9e4 · 4f3c9e4
1 parent f5e84c5
commit 4f3c9e4
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 11 deletions.
diff --git a/src/Translator/src/Intl/ErrorKind.php b/src/Translator/src/Intl/ErrorKind.php
@@ -14,7 +14,7 @@
 /**
  * Adapted from https://github.com/formatjs/formatjs/blob/590f1f81b26934c6dc7a55fff938df5436c6f158/packages/icu-messageformat-parser/error.ts#L9-L77.
  *
- * @experimental
+ * @internal
  */
 final class ErrorKind
 {

diff --git a/src/Translator/src/Intl/IntlMessageParser.php b/src/Translator/src/Intl/IntlMessageParser.php
@@ -18,9 +18,9 @@
 /**
  * Adapted from https://github.com/formatjs/formatjs/blob/590f1f81b26934c6dc7a55fff938df5436c6f158/packages/icu-messageformat-parser/parser.ts.
  *
- * @experimental
+ * @internal
  */
-class IntlMessageParser
+final class IntlMessageParser
 {
     private readonly AbstractString $message;
     // Minor optimization, this avoid a lot of calls to `$this->message->length()`
@@ -890,7 +890,7 @@ private function char(): int
 
         $code = $this->message->codePointsAt($offset)[0] ?? null;
         if (null === $code) {
-            throw new \Exception("Offset {$offset} is at invalid UTF-16 code unit boundary");
+            throw new \Exception("Offset {$offset} is at invalid UTF-16 code unit boundary.");
         }
 
         return $code;
@@ -978,7 +978,7 @@ private function bumpUntil(string $pattern): bool
     private function bumpTo(int $targetOffset)
     {
         if ($this->position->offset > $targetOffset) {
-            throw new \Exception(\sprintf('targetOffset %s must be greater than or equal to the current offset %d', $targetOffset, $this->position->offset));
+            throw new \Exception(\sprintf('targetOffset "%s" must be greater than or equal to the current offset %d', $targetOffset, $this->position->offset));
         }
 
         $targetOffset = min($targetOffset, $this->messageLength);
@@ -988,7 +988,7 @@ private function bumpTo(int $targetOffset)
                 break;
             }
             if ($offset > $targetOffset) {
-                throw new \Exception("targetOffset {$targetOffset} is at invalid UTF-16 code unit boundary");
+                throw new \Exception("targetOffset {$targetOffset} is at invalid UTF-16 code unit boundary.");
             }
 
             $this->bump();

diff --git a/src/Translator/src/Intl/Location.php b/src/Translator/src/Intl/Location.php
@@ -14,7 +14,7 @@
 /**
  * Adapted from https://github.com/formatjs/formatjs/blob/590f1f81b26934c6dc7a55fff938df5436c6f158/packages/icu-messageformat-parser/types.ts#L58-L61.
  *
- * @experimental
+ * @internal
  */
 final class Location
 {

diff --git a/src/Translator/src/Intl/Position.php b/src/Translator/src/Intl/Position.php
@@ -14,7 +14,7 @@
 /**
  * Adapted from https://github.com/formatjs/formatjs/blob/590f1f81b26934c6dc7a55fff938df5436c6f158/packages/icu-messageformat-parser/types.ts#L53-L57.
  *
- * @experimental
+ * @internal
  */
 final class Position
 {

diff --git a/src/Translator/src/Intl/SkeletonType.php b/src/Translator/src/Intl/SkeletonType.php
@@ -14,7 +14,7 @@
 /**
  * Adapted from https://github.com/formatjs/formatjs/blob/590f1f81b26934c6dc7a55fff938df5436c6f158/packages/icu-messageformat-parser/types.ts#L48-L51.
  *
- * @experimental
+ * @internal
  */
 final class SkeletonType
 {

diff --git a/src/Translator/src/Intl/Type.php b/src/Translator/src/Intl/Type.php
@@ -14,7 +14,7 @@
 /**
  * Adapted from https://github.com/formatjs/formatjs/blob/590f1f81b26934c6dc7a55fff938df5436c6f158/packages/icu-messageformat-parser/types.ts#L8-L46.
  *
- * @experimental
+ * @internal
  */
 final class Type
 {

diff --git a/src/Translator/src/Intl/Utils.php b/src/Translator/src/Intl/Utils.php
@@ -14,7 +14,7 @@
 use Symfony\Component\String\AbstractString;
 
 /**
- * @experimental
+ * @internal
  */
 final class Utils
 {

diff --git a/src/Translator/src/MessageParameters/Extractor/ExtractorInterface.php b/src/Translator/src/MessageParameters/Extractor/ExtractorInterface.php
@@ -15,6 +15,7 @@
  * @author Hugo Alliaume <hugo@alliau.me>
  *
  * @experimental
+ * @internal
  */
 interface ExtractorInterface
 {

diff --git a/src/Translator/src/MessageParameters/Extractor/IntlMessageParametersExtractor.php b/src/Translator/src/MessageParameters/Extractor/IntlMessageParametersExtractor.php
@@ -18,6 +18,7 @@
  * @author Hugo Alliaume <hugo@alliau.me>
  *
  * @experimental
+ * @internal
  */
 final class IntlMessageParametersExtractor implements ExtractorInterface
 {

diff --git a/src/Translator/src/MessageParameters/Extractor/MessageParametersExtractor.php b/src/Translator/src/MessageParameters/Extractor/MessageParametersExtractor.php
@@ -15,6 +15,7 @@
  * @author Hugo Alliaume <hugo@alliau.me>
  *
  * @experimental
+ * @internal
  */
 final class MessageParametersExtractor implements ExtractorInterface
 {

diff --git a/src/Translator/src/MessageParameters/Printer/TypeScriptMessageParametersPrinter.php b/src/Translator/src/MessageParameters/Printer/TypeScriptMessageParametersPrinter.php
@@ -15,6 +15,7 @@
  * @author Hugo Alliaume <hugo@alliau.me>
  *
  * @experimental
+ * @internal
  */
 final class TypeScriptMessageParametersPrinter
 {