[Map][Leaflet] Fix Popup's automatic-content #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
fix/map-leaflet-infowindow-null
branch
from
cd33c3a to
33fce10
Compare
|
Nice fix! I like the (concise and modern) JS code that you used here. Thanks Hugo. |
|
Thanks for quick merging Javier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaflet's Popup does not have
headerContent, but GoogleMaps does.To prevent too many issues when developpers change for another Map Bridge, with Simon we took the decision to render
headerContentandcontentdata in Leaflet Popup's content.But it looks like I've did things wrong, if I don't specify
headerContent, then anulltext is displayed in the popup:Because in JavaScript,
null + 'foo'givesnullfoo:(With this PR, the popup is now nicely displayed:
