[Map] Add the possibility to not configure map zoom/center if fit bounds to markers #2045
Conversation
Kocal
force-pushed
the
feat/ux-map-no-errors-if-fit-bounds
branch
2 times, most recently
from
3acffb5 to
9914af6
Compare
Kocal
force-pushed
the
feat/ux-map-no-errors-if-fit-bounds
branch
from
9914af6 to
b3e6412
Compare
| @@ -24,7 +24,7 @@ class MapTest extends TestCase | |||
| public function testCenterValidation(): void | |||
| { | |||
| self::expectException(InvalidArgumentException::class); | |||
| self::expectExceptionMessage('The center of the map must be set.'); | |||
| self::expectExceptionMessage('The map "center" must be explicitly set when not enabling "fitBoundsToMarkers" feature.'); | |||
There was a problem hiding this comment.
I still think we should make it true per default 🙊
There was a problem hiding this comment.
More seriously, fit bounds to marker is not a feature from Google Maps or Leaflet, it's a feature from UX Map, and enable it automatically depending of certains conditions looks wrong to me, because it behaves differently than GMaps/Leaflet in this situation.
If we make it true by default, we should disable it (if not explicitly enabled) if the dev provide a center / zoom configuration.
But, that's true it can offers a better DX, because actually if you create a map (without configuring the zoom / center, fit bounds to marker), nothing is displayed (either grey map, or errors in console).
If we enable it by default (and disable it if necessary), the user will see its map without any necessary configuration
|
Thanks Hugo. |
Following a review from @smnandre in #1937 or in our Slack DMs.
Forcing the developper to explicitly configure the center/zoom of the map does not make sense if
fitBoundsToMarkerfeature is enabled.Also, I prefer throw exceptions instead of automatically enable
fitBoundsToMarkerif there are markers and center/zoom are not configured, it's more explicit like that and it mimic the Leaflet/GoogleMaps behaviors (the map can't be rendered if no center/zoom, andfitBoundsToMarkeris a UX Map's feature).