Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Map] Rename render_map Twig function ux_map #2073

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

smnandre
Copy link
Member

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Context

As we recently saw with the cva function and forgot to do here: we should prefix every new component / package / Twig function or filter with ux to avoid conflict with existing codebases... and with future symfony or twig new methods.

This PR

This PR renames render_map (inspired by charts hjs "render_chart") into ux_map (in line with what we did for UX Icons)

<div>
-    {{ render_map(map) }}
+    {{ ux_map(map) }}
</div>

Next

We can keep the render_map for some time, but it's marked as deprecated right now, and i think this is the good moment to update documentation, to limit future BC break / changes for users (even if we are in experimental)

Website

Once this once is merged, the website page will need to be updated

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 16, 2024
@smnandre smnandre requested review from Kocal and kbond August 16, 2024 19:11
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

TIL about deprecated/deprecating_package :)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 16, 2024
@kbond
Copy link
Member

kbond commented Aug 20, 2024

Thanks Simon.

@kbond kbond merged commit 4bb9ee7 into symfony:2.x Aug 20, 2024
42 checks passed
@Kocal Kocal deleted the feat/use-ux-prefix branch August 20, 2024 17:50
Kocal added a commit that referenced this pull request Sep 25, 2024
This PR was merged into the 2.x branch.

Discussion
----------

[Site] Fix deprecated function call

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| Issues        | -
| License       | MIT

Next to #2073

Commits
-------

fed198c [Site] Fix deprecated function call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants