Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Twig extension return types #2076

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix Twig extension return types #2076

merged 1 commit into from
Aug 20, 2024

Conversation

smnandre
Copy link
Member

Prepare Twig 4.0 compatibility

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Aug 17, 2024
@smnandre smnandre requested a review from Kocal August 17, 2024 21:49
Kocal
Kocal approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goodbye-my-friends

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Aug 18, 2024
kbond
kbond approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon, mind rebasing?

@smnandre
Fix Twig extension return types
34d1b75 
Prepare Twig 4.0 compatibility
@smnandre smnandre force-pushed the fix/twig-extension-return-types branch from c42b964 to 34d1b75 Compare August 20, 2024 19:20
@smnandre
Copy link
Member Author

Good @kbond

@smnandre smnandre requested a review from kbond August 20, 2024 19:20
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Aug 20, 2024
@kbond
Copy link
Member

kbond commented Aug 20, 2024

Thanks Simon.

@kbond kbond merged commit 348d260 into symfony:2.x Aug 20, 2024
43 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kocal Kocal Kocal approved these changes

@kbond kbond Awaiting requested review from kbond

Assignees
No one assigned
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smnandre @kbond @Kocal @carsonbot