Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropzone] Enable file replacement via "drag-and-drop" #2154

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[Dropzone] Enable file replacement via "drag-and-drop" #2154

merged 1 commit into from
Oct 7, 2024

Conversation

rrr63
Copy link
Contributor

@rrr63 rrr63 commented Sep 11, 2024

Q A
Bug fix? yes
New feature? no
Issues Fix #1480
License MIT

Adding dragenter event to allow file replacement

@carsonbot carsonbot added Bug Bug Fix Dropzone Status: Needs Review Needs to be reviewed labels Sep 11, 2024
@smnandre
Copy link
Member

Hi @rrr63 ! Thank you for this PR

Could you add just a screenshot or two, for other to understand what you're adding ?

I'm wondering, you add on dragEnter, but you don't revert if the drag is canceled ?

Also, it would be great to add a test or two :)

@rrr63
Copy link
Contributor Author

rrr63 commented Sep 12, 2024

Hi @smnandre ,

You're right, i canceled when the drag leaves, and added a test for both, enter and leave.
Both, enter and leave are in the same test to get the right drag area from enter event.

Demo :
dropzone

@smnandre
Copy link
Member

Wow, thank you very much! I'll try tonight but this will probably more be this week-end :)

@smnandre smnandre added Feature New Feature and removed Bug Bug Fix labels Sep 12, 2024
@smnandre smnandre changed the title [Dropzone] Fix drag-and-drop replacement issue [Dropzone] Enable file replacement via "drag-and-drop" Sep 12, 2024
@smnandre
Copy link
Member

Could you add a entry in the CHANGELOG (inside the Dropzone folder) ? Next version will be 2.20

@rrr63
Copy link
Contributor Author

rrr63 commented Sep 12, 2024

Sure i can, just copied the title :)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 12, 2024
@smnandre smnandre requested a review from Kocal September 12, 2024 19:02
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Reviewed Has been reviewed by a maintainer labels Sep 12, 2024
@smnandre
Copy link
Member

smnandre commented Oct 7, 2024

(did something weird here, but this should be / will be merged ... sorry for my mittens)

@smnandre
Copy link
Member

smnandre commented Oct 7, 2024

Thank you @rrr63.

@smnandre smnandre merged commit ce483d7 into symfony:2.x Oct 7, 2024
59 checks passed
smnandre added a commit that referenced this pull request Oct 7, 2024
@smnandre
bug #2154 [Dropzone] Enable file replacement via "drag-and-drop" (rrr63)
45770b0 
This PR was merged into the 2.x branch.

Discussion
----------

[Dropzone] Enable file replacement via "drag-and-drop"

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| Issues        | Fix #1480
| License       | MIT

Adding `dragenter` event to allow file replacement

Commits
-------
@Chris53897 Chris53897 mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smnandre smnandre smnandre approved these changes

@Kocal Kocal Awaiting requested review from Kocal

Assignees
No one assigned
Labels
Dropzone Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UX Dropzone] drag'n'drop replacement fail
3 participants
@rrr63 @smnandre @carsonbot