[StimulusBundle] Normalize Stimulus controller name in event name #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Bug
7-zete-7
commented
Sep 12, 2024
smnandre
reviewed
Sep 12, 2024
smnandre
added
Status: Needs Work
7-zete-7
added a commit
to 7-zete-7/ux
that referenced
this pull request
Sep 28, 2024
Applies suggestion symfony#2159 (comment)
carsonbot
added
Status: Needs Review
7-zete-7
added a commit
to 7-zete-7/ux
that referenced
this pull request
Sep 28, 2024
Applies suggestion symfony#2159 (comment)
7-zete-7
force-pushed
the
patch-1
branch
2 times, most recently
from
b1426f2 to
4db6184
Compare
7-zete-7
added a commit
to 7-zete-7/ux
that referenced
this pull request
Sep 28, 2024
Applies suggestion symfony#2159 (comment)
Updated |
|
No more unnecessary escaping. Great! |
Kocal
reviewed
Sep 28, 2024
Comment on lines
226
to
231
| private function normalizeEventName(?string $eventName): ?string | ||
| { | ||
| if (null === $eventName) { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
I suggest to not support nullable string here, but only non-nullable string.
Suggested change
| private function normalizeEventName(?string $eventName): ?string | |
| { | |
| if (null === $eventName) { | |
| return null; | |
| } | |
| private function normalizeEventName(string $eventName): string | |
| { |
The null check should be done before calling this method.
There was a problem hiding this comment.
Moved null value check out of the method.
There was a problem hiding this comment.
Please move those tests inside src/StimulusBundle/tests/Dto/StimulusAttributesTest.php file 🙏🏻
There was a problem hiding this comment.
Has a change been made since your comment? Cause I dont see the différence now
There was a problem hiding this comment.
Moved the test to the common class.
7-zete-7
added a commit
to 7-zete-7/ux
that referenced
this pull request
Sep 28, 2024
…) method Applies suggestion symfony#2159 (comment)
7-zete-7
added a commit
to 7-zete-7/ux
that referenced
this pull request
Sep 28, 2024
…malizeEventName() method Resolves suggestion symfony#2159 (comment)
|
Thank you @7-zete-7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to use non-normalized Stimulus controller names when describing actions on events from other Stimulus controllers.