Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TwigComponent] Optimize ComponentFactory #2201

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[TwigComponent] Optimize ComponentFactory #2201

merged 1 commit into from
Sep 24, 2024

Conversation

smnandre
Copy link
Member

Q A
Bug fix? no
New feature? no
Issues Fix #...
License MIT

Some internal refactor focused on the Component Factory / Anonymous components usage.

  • Optimize the hot path
  • Store anonymous template resolution
  • Avoid anonymous checks for class-based components
  • Add ComponentFactory unit tests
  • Add ComponentMetadata::isAnonymous() method
  • Fix loop
  • Reuse metadata to instanciate and mount component

Other PRs will follow :)

@smnandre smnandre requested a review from kbond September 24, 2024 01:22
@smnandre
Copy link
Member Author

(ignore the fabpot one)

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Sep 24, 2024
@javiereguiluz
Copy link
Member

Thanks Simon.

@javiereguiluz javiereguiluz merged commit c7e4532 into symfony:2.x Sep 24, 2024
7 of 8 checks passed
@smnandre smnandre mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@kbond kbond kbond approved these changes

@Kocal Kocal Kocal approved these changes

Assignees
No one assigned
Labels
Status: Reviewed Has been reviewed by a maintainer TwigComponent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smnandre @javiereguiluz @kbond @Kocal @carsonbot