[TwigComponent] Fix ux:icon & ux:map renders #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you link the Blackfire profiles delta plz? |
javiereguiluz
approved these changes
Sep 27, 2024
carsonbot
added
Status: Reviewed
kbond
approved these changes
Sep 27, 2024
javiereguiluz
force-pushed
the
fix/remove-twig-listeners
branch
from
ec7ccd7 to
24c1cb2
Compare
|
Thank you Simon. |
| @@ -108,6 +110,10 @@ class_exists(AbstractArgument::class) ? new AbstractArgument(\sprintf('Added in | |||
| $container->register('.ux.twig_component.twig.component_runtime', ComponentRuntime::class) | |||
| ->setArguments([ | |||
| new Reference('ux.twig_component.component_renderer'), | |||
| service_locator([ | |||
| 'ux:icon' => service('.ux_icons.twig_icon_runtime')->nullOnInvalid(), | |||
| 'ux:map' => service('ux_map.twig_runtime')->nullOnInvalid(), | |||
There was a problem hiding this comment.
chiming here a bit late: this doesn't work
a service locator must point to non-null references
when these are turned into nulls, XmlDumper explodes (and that's a symptom of this code, which is not "legal")
Also, from a design pov, this looks super hardcoded. How can one pass more things to the locator?
This should use a tagged locator instead.
There was a problem hiding this comment.
This was spotted by the CI BTW:
https://github.com/symfony/ux/actions/runs/11071829929/job/30764609180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change implementation to avoid many dispatched events for nothing
Add a conflict in symfony/ux-map and symfony/ux-icons to synchronise the 3 packages to 2.21
Performance gain around 20%