Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Map] Update documentation #2317

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

smnandre
Copy link
Member

@smnandre smnandre commented Nov 1, 2024

First round of changes, very open to feedback / suggestions
(it's a draft to start iterating)

related: #2117

@smnandre smnandre requested a review from Kocal as a code owner November 1, 2024 05:46
@carsonbot carsonbot added Map Status: Needs Review Needs to be reviewed labels Nov 1, 2024
@smnandre smnandre added the docs Improvements or additions to documentation label Nov 1, 2024
Copy link
Member

@Kocal Kocal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@carsonbot carsonbot added Status: Reviewed Has been reviewed by a maintainer and removed Status: Needs Review Needs to be reviewed labels Nov 1, 2024
@smnandre
Copy link
Member Author

smnandre commented Nov 3, 2024

@Kocal Do you want to wait for other contributions here, or do we merge, and iterate once released (as for now documentation is a bit light -- my fault) .. :)

@Kocal
Copy link
Member

Kocal commented Nov 3, 2024

@smnandre you can merge if you want, it's fine for me :)

@smnandre smnandre force-pushed the map/doc-function-component branch from eaadd41 to 9eb8539 Compare November 4, 2024 01:07
@smnandre smnandre merged commit 1841f55 into symfony:2.x Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation Map Status: Reviewed Has been reviewed by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants