-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Drop format, lint, check-format and check-lint commands, replace them with check and ci commands #2428
Conversation
@Kocal Re, you are quicker than me I was doing make a PR, so great to see that :) A little thing about the "--write", it sounds as a low level of details, I found the "--fix" shorter and it is more humanized...but the "--write" is the first accepted option and "--fix" is an alias...(My 🧠 swims too much with cs-fixer, maybe :D) |
- `yarn run lint`: lint assets from the package, | ||
- `yarn run format`: format assets from the package. | ||
- `yarn run check`: run the formatter, linter, and sort imports, and fails if any modifications | ||
- `yarn run check --write`: run the formatter, linter, imports sorting, and write modifications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to update the contributing guide 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, don't worry that's fine :)
1a068f9
to
51f7478
Compare
I understand your point, but I believe it can be the same scenario with Let's keep |
…ce them with check and ci commands Co-authored-by: Florian Cellier <florian.cellier@sensiolabs.com>
51f7478
to
36d04ff
Compare
'just put you as co-author ;) |
@Kocal so you are "--write" by XP, it is better ^^ |
Is it possible to have "yarn run check" and "yarn run fix" ? If not i'll do my aliases :) |
|
Following #2423 (comment).
When I've migrated from ESLint and Prettier to Biome.js, I kept commands
yarn lint
,yarn format
(andyarn check-
) for historical and simplicity reasons, because it was two separate tools.Now that we use a single tool, we can use its two dedicated commands:
biome check
, likebiome format + biome lint + imports sorting
biome ci
, for the CI (it does not write files)cc @chadyred