Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Visual improvments on IconModal #2465

Merged
merged 2 commits into from
Dec 23, 2024
Merged

[Site] Visual improvments on IconModal #2465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21d9557
[Site] Improve contrast on IconModal
Kocal Dec 23, 2024
610db72
[Site] Improve IconModal display on mobile
Kocal Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions ux.symfony.com/assets/styles/components/_IconModal.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
min-height: 1rem;
max-width: 100vw;
max-height: 100vh;
overflow: clip;
overflow: auto;
padding: 1rem 1.5rem;
background: var(--bs-body-bg);
color: var(--bs-body-color);
Expand Down Expand Up @@ -59,7 +59,6 @@

.IconModal__body {
display: grid;
grid-template-columns: 300px 1fr;
gap: 1.5rem;
}

Expand Down Expand Up @@ -176,7 +175,7 @@
padding: 0.35rem 0.5rem;
border-radius: .5rem;
border: 1px solid var(--bs-dark-border-subtle);
background: var(--bs-secondary-bg-subtle);
background: var(--bs-secondary-bg);
overflow: hidden;
position: relative;
opacity: .8;
Expand Down Expand Up @@ -212,7 +211,7 @@
}

.IconModal__code span {
color: lightskyblue;
color: var(--bs-code-color);
}

.IconModal__copy {
Expand All @@ -239,3 +238,20 @@
padding-top: 0;
}

.IconModal__main .TabBody {
padding-block-end: 0;
}

@media screen and (max-width: 768px) {
.IconModal {
padding: .5rem;
margin: .5rem;
width: auto;
height: auto;
}
}
@media screen and (min-width: 768px) {
.IconModal__body {
grid-template-columns: 300px 1fr;
}
}
2 changes: 1 addition & 1 deletion ux.symfony.com/assets/styles/components/_Tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
transition: background-color 150ms ease-in-out;
}
.TabControl.active {
background: var(--bs-secondary-bg);
background: var(--bs-tertiary-bg);
}

.TabPanel {
Expand Down
Loading