[Autocomplete] max_results option is not passed to parent entity #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daFish
force-pushed
the
fix/autocomplete-max-results-for-ajax
branch
from
297918e to
65af192
Compare
daFish
force-pushed
the
fix/autocomplete-max-results-for-ajax
branch
from
65af192 to
43e74fe
Compare
|
Great catch and excellent coverage in the test. Thank you @daFish! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an oversight from #478 when it comes to passing the option from types that use
#[AsEntityAutocompleteField].This fix removes the unsetting of
$options['max_results']from theAutocompleteEntityTypeSubscriberto allow passing the information. I also extended the tests to cover this case.