-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies for webpack 3 (when possible) #38
Comments
I did an update to see how much work it would require.
We have to wait for these issues to be resolved before we can properly update to Webpack 3 babel-loader extract-text-webpack-plugin webpack-dev-middleware webpack-dev-server |
packages-lock.json makes sense only in projects (it has no effect for packages downloaded from npm as dependencies). So nothing forbids you from using npm 5 in your own project when using Encore. |
@stof |
well, yarn is still usable on Node 8. And we already test Encore on Node 8 |
@stof I am missing your point. |
Hi guys! Right now we've chosen to use Yarn to manage Encore's dependencies and I don't see a reason to change that right now. And whether we commit a But, we do need to regularly update the So:
I'm going to rename this issue to be about updating to Webpack 3, and we can use it to track that. Thanks! |
I created #39 to discuss the part about improving the testing of different deps on CI |
I think more loaders need to be updated for Webpack than the one listed above. We also need to have Webpack 3 support for the optional loaders needing to be installed by users (less, sass, react, vue, etc...) |
@weaverryan |
We use it on Travis (actually, Travis uses it automatically when it sees a yarn.lock file): https://travis-ci.org/symfony/webpack-encore/jobs/244828200#L236 |
@stof Should we change the AppVeyor to work the same way?
@weaverryan Why would this be an issue? This is how most nodejs packages work. |
@DaRamirezSoto please discuss the CI part in #39. Let's keep this issue focused on Webpack 3 |
Ah, yes! That was an oversight - it should also use yarn... which can be installed via npm: https://github.com/webpack/webpack/blob/master/appveyor.yml#L24 |
The text was updated successfully, but these errors were encountered: