Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack 3 to peerDependencies #199

Closed
1 of 2 tasks
chearon opened this issue Jun 19, 2017 · 1 comment
Closed
1 of 2 tasks

Add webpack 3 to peerDependencies #199

chearon opened this issue Jun 19, 2017 · 1 comment

Comments

@chearon
Copy link

chearon commented Jun 19, 2017

Hello,

Webpack 3 was just released and I noticed this (as a dependency of karma-webpack) doesn't have version 3 of webpack in peerDependencies. I haven't looked at the source here, but I am at least one data point that can say it is working fine in webpack 3. The list of breaking changes was small.

If you could consider adding || ^3, it'd reduce warnings for those of us who've upgraded. Thanks!


  • Operating System: macOS Sierra
  • Node Version: 6
  • NPM Version: 3.10.10
  • webpack version: 3.0.0
  • webpack-dev-middleware Version: 1.10.2
  • This is a feature request
  • This is a bug

Expected Behavior

Silent install

Actual Behavior

"webpack-dev-middleware@1.10.2" has incorrect peer dependency "webpack@1 || ^2.1.0-beta || ^2.2.0-rc.0".

@shellscape
Copy link
Contributor

Fixed by #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants