Fix the mini-css-extract-plugin 0.4.3 issue and increase min. allowed Webpack version #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes both of the issues detected in #403:
Set the maximum allowed version for
mini-css-extract-plugin
to 0.4.2 (since 0.4.3 doesn't work with the current version of the webpack-manifest-plugin, see Incompatibility between mini-css-extract-plugin 0.4.3 and the manifest plugin #404). This is a temporary solution, once it's fixed (either in mini-css-extract-plugin or in weback-manifest-plugin) we'll have to change it again.Set the minimum allowed version for
webpack
to 4.20.0. The previous one (4.0.0) seemed to breakmini-css-extract-plugin
(see https://travis-ci.org/Lyrkan/webpack-encore/jobs/439810002).