Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack dev server updated from 3.1.14 to 3.7.2 #598

Closed
wants to merge 2 commits into from
Closed

Webpack dev server updated from 3.1.14 to 3.7.2 #598

wants to merge 2 commits into from

Conversation

gustawdaniel
Copy link
Contributor

@gustawdaniel gustawdaniel commented Jun 28, 2019

For the sake of #596 packeges webpack-dev-server and url-loader are updated to newest version.

@Lyrkan
Copy link
Collaborator

Lyrkan commented Jun 28, 2019

Hi @gustawdaniel,

I don't think that updating webpack-dev-server is required, our current range (^3.1.14) already allows people to use 3.7.2.

As for url-loader@^2 there are some things to consider:

  • it should already be possible to use url-loader@^2 with Encore since that's a dev-dependency (maybe with a warning but it won't prevent it from working fine)
  • the version is quite recent so it may be a good idea to wait for a bit before updating (for instance 2.0.0 introduced the following regression which was fixed 3 days ago: Specifying options as a query string does not work anymore webpack-contrib/url-loader#183)
  • this is a major bump which introduces breaking changes: one of them being the min Node.js version set to >=8.9.0. It means that people using >= 8.0.0 <8.9.0 won't be able to use the url-loader without a warning since our version requirement is 8.* || >= 10.*). One solution to that would be to allow both url-loader@^1 and url-loader@^2 (Encore doesn't set any option so it should not break anything).

@gustawdaniel
Copy link
Contributor Author

Ok. So I closing this pull request. Thanks for explaination @Lyrkan

@Lyrkan
Copy link
Collaborator

Lyrkan commented Jun 28, 2019

As I said I'm not entirely against this, having something like "url-loader": "1.* || 2.*" would be a valid way of doing it without requiring people with to update Node.js or the url-loader.

@gustawdaniel
Copy link
Contributor Author

gustawdaniel commented Jun 28, 2019

I removed fork so there is unknown repository so i created it again in:

#599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants