Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping preset-env to version that depends on @babel/plugin-proposal-class-properties #889

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

weaverryan
Copy link
Member

This helps fix symfony/stimulus-bridge#16

Basically, in the Encore recipe, we add the @babel/plugin-proposal-class-properties plugin in webpack.config.js. But, this is not necessarily in the user's project. But 7.10 of @babel/preset-env started including this package.

So it's a bit of an odd solution, as we're bumping this dependency so that users can do something simpler in userland config, but I think it's the simplest path. This is basically why most users already are able to use Stimulus (and the class properties it uses) without issues, as most people probably already have @babel/preset-env 7.10 or higher.

@weaverryan weaverryan mentioned this pull request Jan 23, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant