Double-take on tests, add some more checks. #83
rsdyAnnotations
2 errors and 6 warnings
|
field `0` of struct `zerostash_files::Tree` is private:
zerostash-fuse/src/mount.rs#L191
error[E0616]: field `0` of struct `zerostash_files::Tree` is private
--> zerostash-fuse/src/mount.rs:191:44
|
191 | if let Some(node) = index.tree.0.get(v) {
| ^ private field
|
|
tests
Process completed with exit code 1.
|
|
constant `SERVICE_NAME` is never used:
zerostash/src/config/symmetric_key.rs#L6
warning: constant `SERVICE_NAME` is never used
--> zerostash/src/config/symmetric_key.rs:6:7
|
6 | const SERVICE_NAME: &str = "dev.symmetree.zerostash";
| ^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
unused variable: `stash`:
zerostash/src/config/symmetric_key.rs#L77
warning: unused variable: `stash`
--> zerostash/src/config/symmetric_key.rs:77:42
|
77 | pub fn interactive_credentials(self, stash: &str) -> Result<(SecretString, SecretString)> {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_stash`
|
|
unused variable: `stash`:
zerostash/src/config/symmetric_key.rs#L49
warning: unused variable: `stash`
--> zerostash/src/config/symmetric_key.rs:49:34
|
49 | pub fn fill_random(mut self, stash: &str) -> Result<Self> {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_stash`
|
= note: `#[warn(unused_variables)]` on by default
|
|
this let-binding has unit value:
zerostash-files/src/tree.rs#L371
warning: this let-binding has unit value
--> zerostash-files/src/tree.rs:371:13
|
371 | / _ = entries.upsert(
372 | | name.into(),
373 | | move || noderef,
374 | | |_, v| {
... |
377 | | },
378 | | );
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
help: omit the `let` binding
|
371 ~ entries.upsert(
372 + name.into(),
373 + move || noderef,
374 + |_, v| {
375 + noderef = *v;
376 + update = true;
377 + },
378 ~ );;
|
|
|
this let-binding has unit value:
zerostash-files/src/tree.rs#L371
warning: this let-binding has unit value
--> zerostash-files/src/tree.rs:371:13
|
371 | / _ = entries.upsert(
372 | | name.into(),
373 | | move || noderef,
374 | | |_, v| {
... |
377 | | },
378 | | );
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
help: omit the `let` binding
|
371 ~ entries.upsert(
372 + name.into(),
373 + move || noderef,
374 + |_, v| {
375 + noderef = *v;
376 + update = true;
377 + },
378 ~ );;
|
|
|
this let-binding has unit value:
zerostash-files/src/tree.rs#L371
warning: this let-binding has unit value
--> zerostash-files/src/tree.rs:371:13
|
371 | / _ = entries.upsert(
372 | | name.into(),
373 | | move || noderef,
374 | | |_, v| {
... |
377 | | },
378 | | );
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
= note: `#[warn(clippy::let_unit_value)]` on by default
help: omit the `let` binding
|
371 ~ entries.upsert(
372 + name.into(),
373 + move || noderef,
374 + |_, v| {
375 + noderef = *v;
376 + update = true;
377 + },
378 ~ );;
|
|