-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
variables.tf
Outdated
# See: https://github.com/hashicorp/terraform/issues/25609#issuecomment-1472119672 | ||
|
||
value = null | ||
precondition { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This precondition block is what forces our minimum Terraform version to be >= 1.2
.
Currently, the latest version of Terraform is 1.6.5. Are we comfortable with saying that to use the gcp_connector
you must have a version >= 1.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it... I do think we can get away with it, though it would be good, if possible, to find out if our existing customers who are interested in using us with GCP are able to do this.
|
||
<!-- BEGIN_TF_DOCS --> | ||
<!-- END_TF_DOCS --> | ||
<!-- BEGINNING OF PRE-COMMIT-TERRAFORM DOCS HOOK --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to make the TF Doc generation part of our pre-commit hooks, so that we can preview the README in the PRs before merging, instead of generating them after they are merged to main.
Thoughts?
Description
Implements the
gcp_connector
module, which:Adds a CircleCI pipeline to run
terraform/fmt
andterraform/validate
as required checks for PRsAdds a
CODEOWNER
file as well as a PR template fileTesting
sym-intergation-leslie
project in thecompliance.dev
test account like so: