This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Allow setting JWT env var #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llam15
reviewed
Nov 28, 2023
There was a problem hiding this comment.
Yay! Thank you for the contribution! This is excellent, I've been wanting to add some sort of customizable authentication to the provider.
Overall, it looks good, just a couple thoughts about wording and terminology. With those changes and passing checks, we should be good to go, I think. Thank you again!
Co-authored-by: Leslie Lam <leslie@llam.dev>
Co-authored-by: Leslie Lam <leslie@llam.dev>
|
Thanks @llam15, not sure why I didn't see the notification! |
llam15
approved these changes
Dec 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently you can't set up two Sym providers in one terraform project because the JWT is expected to be in a specific environment variable.
This change adds a
jwt_env_varallowing different provider instances to use different JWTs within the same terraform project.My Go isn't the best so apologies if the code style isn't quite right or I've missed something.