Add MembersLogin delegate, for external log in #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an account gets deleted, but user is still loggued in, this method would crash because we are calling a function on null. This fix prevents it.
Usign a section that does not contains a password has been discussed in issue #274, but the PR did not actually provide a way to let other extension authenticate the user. Only if the members section DOES BOT contains a password field, the new MembersLogin will be called. By default, log in is refused and extension must explicitly set the required parameters with good values for the login to succeed.
Calling isset on an always declared variable always yeilds true. This is not what we want: we want to check if we have a value.
|
cc @jonmifsud |
michael-e
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usign a section that does not contains a password has been discussed in
issue #274, but the PR did not actually provide a way to let other
extension authenticate the user.
Only if the members section DOES BOT contains a password field, the new
MembersLogin will be called. By default, log in is refused and extension
must explicitly set the required parameters with good values for the
login to succeed.
Mostly check 99f24e8
The other are simple bug fixes and code format