Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure event save works with different admin paths #307

Merged
merged 2 commits into from
Dec 4, 2017

Conversation

jonmifsud
Copy link
Member

Removal of hardcoded symphony path, and using the correct context variable for the complete admin path.

@nitriques nitriques merged commit 64bb32f into symphonycms:integration Dec 4, 2017
@wdebusschere
Copy link

Not yet everywhere ok, when i try to add an ETM to the generate recovery code event, i get an error, nothing happens. In symphony log: User Notice: FrontendPageNotFoundException 1024 - The page you requested, /symphony/extension/members/events/, does not exist. on line 330 of /Users/xxx/Sites/xxx/symphony/lib/toolkit/class.frontendpage.php

@nitriques
Copy link
Member

@wdebusschere Can you try to fire the event with the ?debug querystring in your form's action attribute ?

@wdebusschere
Copy link

@nitriques This happens in the eventdetail page of the members_generate_recovery_code in the symphony admin, when i try to choose the emailtemplate. Form action url is correct, but the post url is wrong http://localhost/xxx/symphony/extension/members/events/ should be http://localhost/xxx/customesymphony/extension/members/events/

Error is in L13 of https://github.com/symphonycms/members/edit/master/assets/members.events.js
url: Symphony.Context.get('symphony') + '/extension/members/events/',

@nitriques
Copy link
Member

Well the code is correct, I do not get why you are having that value in there.
Can you run this in your dev tools and give me the full output ?

Symphony.Context.get();

@wdebusschere
Copy link

Indeed this info is correct.

The error in dev tools:
symphony.min.js:9 POST http://localhost/xxx/symphony/extension/members/events/ 404 (Not Found)

@nitriques
Copy link
Member

So Symphony.Context.get('symphony') outputs "http://localhost/xxx/customsymphony" right ?

Are you seeing a 302 redirect before the 404 ? Because the code looks ok.

Are you able to load http://localhost/xxx/customsymphony/extension/members/events/ ?

@wdebusschere
Copy link

@nitriques, sorry
I was not using Release 1.10.1, but Release 1.9.0.

This has been solved in 1.10.1
64bb32f

@nitriques
Copy link
Member

@wdebusschere np ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants