Remove NoSingleInterfaceImplementerRule as way complex, let devs hand…

…le it (#156)
symplify · Dec 18, 2024 · 998146c · 998146c
1 parent be7b28d
commit 998146c
Show file tree

Hide file tree

Showing 14 changed files with 0 additions and 384 deletions.
diff --git a/README.md b/README.md
@@ -596,47 +596,6 @@ final class SomeClass
 
 <br>
 
-### NoSingleInterfaceImplementerRule
-
-Interface "%s" has only single implementer. Consider using the class directly as there is no point in using the interface.
-
-```yaml
-rules:
-    - Symplify\PHPStanRules\Rules\NoSingleInterfaceImplementerRule
-```
-
-```php
-class SomeClass implements SomeInterface
-{
-}
-
-interface SomeInterface
-{
-}
-```
-
-:x:
-
-<br>
-
-```php
-class SomeClass implements SomeInterface
-{
-}
-
-class AnotherClass implements SomeInterface
-{
-}
-
-interface SomeInterface
-{
-}
-```
-
-:+1:
-
-<br>
-
 ### NoTestMocksRule
 
 Mocking "%s" class is forbidden. Use direct/anonymous class instead for better static analysis

diff --git a/config/code-complexity-rules.neon b/config/code-complexity-rules.neon
@@ -1,19 +1,2 @@
 rules:
     - Symplify\PHPStanRules\Rules\NoDynamicNameRule
-    - Symplify\PHPStanRules\Rules\NoSingleInterfaceImplementerRule
-
-services:
-    -
-        class: Symplify\PHPStanRules\Collector\InterfaceCollector
-        tags:
-            - phpstan.collector
-
-    -
-        class: Symplify\PHPStanRules\Collector\ImplementedInterfaceCollector
-        tags:
-            - phpstan.collector
-
-    -
-        class: Symplify\PHPStanRules\Collector\InterfaceOfAbstractClassCollector
-        tags:
-            - phpstan.collector
diff --git a/phpstan.neon b/phpstan.neon
@@ -33,9 +33,6 @@ parameters:
         # part of public contract
         - '#Method Symplify\\PHPStanRules\\Tests\\Rules\\(.*?)\\(.*?)Test\:\:testRule\(\) has parameter \$(expectedError(.*?)|expectedErrors) with no value type specified in iterable type array#'
 
-        # overly detailed
-        - '#Class Symplify\\PHPStanRules\\Collector\\(.*?) implements generic interface PHPStan\\Collectors\\Collector but does not specify its types\: TNodeType, TValue#'
-
         # useful to have IDE know the types
         - identifier: phpstanApi.instanceofType
 

diff --git a/src/Collector/ImplementedInterfaceCollector.php b/src/Collector/ImplementedInterfaceCollector.php
diff --git a/src/Collector/InterfaceCollector.php b/src/Collector/InterfaceCollector.php
diff --git a/src/Collector/InterfaceOfAbstractClassCollector.php b/src/Collector/InterfaceOfAbstractClassCollector.php
diff --git a/src/Enum/RuleIdentifier.php b/src/Enum/RuleIdentifier.php
@@ -36,11 +36,6 @@ final class RuleIdentifier
      */
     public const PHP_PARSER_NO_LEADING_BACKSLASH_IN_NAME = 'phpParser.noLeadingBackslashInName';
 
-    /**
-     * @var string
-     */
-    public const NO_SINGLE_INTERFACE_IMPLEMENTER = 'symplify.noSingleInterfaceImplementer';
-
     /**
      * @var string
      */

diff --git a/src/Rules/NoSingleInterfaceImplementerRule.php b/src/Rules/NoSingleInterfaceImplementerRule.php
diff --git a/tests/Rules/NoSingleInterfaceImplementerRule/Fixture/AllowAbstract.php b/tests/Rules/NoSingleInterfaceImplementerRule/Fixture/AllowAbstract.php
diff --git a/tests/Rules/NoSingleInterfaceImplementerRule/Fixture/ImplementsSimpleInterface.php b/tests/Rules/NoSingleInterfaceImplementerRule/Fixture/ImplementsSimpleInterface.php
diff --git a/tests/Rules/NoSingleInterfaceImplementerRule/Fixture/SimpleInterface.php b/tests/Rules/NoSingleInterfaceImplementerRule/Fixture/SimpleInterface.php