Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): submitter docs #2837
feat(docs): submitter docs #2837
Changes from 6 commits
07ac3d1
f8ce0c2
4d79bcf
e1c4eca
48e3b15
de7062c
c8462de
1070d38
6fc663c
6f96038
d13e259
dfbe066
ea4ad48
a11f1d5
135d902
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add corresponding database interactions.
The description of the
SubmitTransaction
method is clear, but it would be beneficial to include details about the corresponding database interactions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing comma.
A comma is missing after "submission".
Committable suggestion
Tools
LanguageTool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe have a Using submitter as a library section? This is just very different than the average user configuring submitter/understanding how it works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace hard tabs with spaces.
The example is clear and demonstrates the correct usage of the
SubmitTransaction
method. However, there are hard tabs that need to be replaced with spaces.Committable suggestion
Tools
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace hard tabs with spaces.
The example is clear and demonstrates the correct usage of the
SubmitTransaction
method. However, there are hard tabs that need to be replaced with spaces.Committable suggestion
Tools
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same goes for this, try to seperate using submitter as a library from as an end user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The details about nonce management, database behavior, and observability metrics are clear and valuable.
Fix grammatical issues and hard tabs.
There are some grammatical issues and hard tabs in the code blocks.
Committable suggestion
Tools
LanguageTool
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the loose punctuation mark.
The documentation correctly lists the observability metrics, but there is a loose punctuation mark.
Tools
LanguageTool