-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Blocked chains #3478
Updating Blocked chains #3478
Changes from all commits
3511c73
31003b0
81e4d56
ff03881
3feab21
cf8cd3e
a89c767
40cd70b
97a185f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -65,6 +65,7 @@ jobs: | |||||||||||||||||||||||||||||
# note: without building a yaml tree of our workflow, we won't be able to tell if golangci version changed so any ci change triggers full lint. | ||||||||||||||||||||||||||||||
files: | | ||||||||||||||||||||||||||||||
.golangci.yml | ||||||||||||||||||||||||||||||
.golangci-version | ||||||||||||||||||||||||||||||
.github/workflows/go.yml | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
|
@@ -336,19 +337,21 @@ jobs: | |||||||||||||||||||||||||||||
- name: Setup cache key | ||||||||||||||||||||||||||||||
run: cp ${{matrix.package}}/go.mod go.mod -v | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
- name: Read golangci-lint version | ||||||||||||||||||||||||||||||
id: golangci_version | ||||||||||||||||||||||||||||||
run: echo "version=v$(cat .golangci-version)" >> $GITHUB_OUTPUT | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
Comment on lines
+340
to
+343
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix potential word splitting issue in shell script. The shell command that reads the version could be vulnerable to word splitting if the version contains spaces. Apply this diff to fix the issue: - - name: Read golangci-lint version
- id: golangci_version
- run: echo "version=v$(cat .golangci-version)" >> $GITHUB_OUTPUT
+ - name: Read golangci-lint version
+ id: golangci_version
+ run: echo "version=v$(cat ".golangci-version")" >> "$GITHUB_OUTPUT" 📝 Committable suggestion
Suggested change
🧰 Tools🪛 actionlint (1.7.4)342-342: shellcheck reported issue in this script: SC2086:info:1:45: Double quote to prevent globbing and word splitting (shellcheck)
Comment on lines
+340
to
+343
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix potential shell injection vulnerability. The version reading step should properly quote the variable to prevent potential shell injection. Apply this diff to fix the security issue: - echo "version=v$(cat .golangci-version)" >> $GITHUB_OUTPUT
+ echo "version=v$(cat .golangci-version)" >> "$GITHUB_OUTPUT" 📝 Committable suggestion
Suggested change
🧰 Tools🪛 actionlint (1.7.4)342-342: shellcheck reported issue in this script: SC2086:info:1:45: Double quote to prevent globbing and word splitting (shellcheck) |
||||||||||||||||||||||||||||||
- name: golangci-lint | ||||||||||||||||||||||||||||||
uses: golangci/golangci-lint-action@v6 | ||||||||||||||||||||||||||||||
with: | ||||||||||||||||||||||||||||||
working-directory: ${{matrix.package}}/ | ||||||||||||||||||||||||||||||
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version | ||||||||||||||||||||||||||||||
version: v1.60.3 | ||||||||||||||||||||||||||||||
# see: https://github.com/golangci/golangci-lint/issues/2654 | ||||||||||||||||||||||||||||||
version: ${{ steps.golangci_version.outputs.version }} | ||||||||||||||||||||||||||||||
args: --timeout=60m | ||||||||||||||||||||||||||||||
env: | ||||||||||||||||||||||||||||||
# GitHub token for annotations (optional) | ||||||||||||||||||||||||||||||
GITHUB_TOKEN: ${{ secrets.WORKFLOW_PAT || secrets.GITHUB_TOKEN }} | ||||||||||||||||||||||||||||||
GOMEMLIMIT: 6GiB | ||||||||||||||||||||||||||||||
GOGC: -1 | ||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||
pr_metadata: | ||||||||||||||||||||||||||||||
# this is needed to prevent us from hitting the github api rate limit | ||||||||||||||||||||||||||||||
name: Get PR Metadata | ||||||||||||||||||||||||||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,3 +130,6 @@ main | |
.devnet/ | ||
|
||
**/__debug_bin* | ||
|
||
# golang-ci-lint binary | ||
contrib/golang-ci-lint/golang-ci-lint |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
1.61.0 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
coverage: | ||
status: | ||
project: | ||
default: | ||
target: '80%' | ||
threshold: '1%' | ||
patch: | ||
default: | ||
target: '80%' | ||
|
||
ignore: | ||
- '**/testdata/**' | ||
- '**/mocks/**' | ||
- '**/*_test.go' | ||
- '**/cmd/**' | ||
- '**/docs/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix potential word splitting in version reading.
The script that reads the version might be susceptible to word splitting if the version contains spaces.
Apply this diff to fix the potential issue:
📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.4)
342-342: shellcheck reported issue in this script: SC2086:info:1:45: Double quote to prevent globbing and word splitting
(shellcheck)