link out to staking in announcement message #3482
Conversation
abtestingalpha
requested review from
bigboydiamonds and
aureliusbtc
as code owners
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@babel/eslint-parser' declared in 'packages/synapse-interface/.eslintrc.js': Cannot find module '@babel/core/package.json'
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Deploying sanguine-fe with
|
| Latest commit: |
0674a57
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://391cca92.sanguine-fe.pages.dev |
| Branch Preview URL: | https://fe-link-banner.sanguine-fe.pages.dev |
Deploying sanguine with
|
| Latest commit: |
ba6c76c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6091cb9f.sanguine.pages.dev |
| Branch Preview URL: | https://fe-link-banner.sanguine.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: Deploy to Vercel (synapse-interface)
- GitHub Check: test
- GitHub Check: lint
- GitHub Check: lint
- GitHub Check: Cloudflare Pages
🔇 Additional comments (3)
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (3)
24-24: Confirm the correctness of the imported URL.
It's good to see theSTAKE_SYN_FOR_CX_URLconstant in a dedicated file for easy maintenance, but please double-check that it points to the correct location before shipping.
80-80: Good approach using a dedicated component.
Replacing a static string with<StakingBannerContent />upholds modularity and keeps the banner content maintainable.
83-83: Please verify the extended announcement date.
Ensure that extending the banner end date to this new day meets the marketing or product requirements.
| const StakingBannerContent = () => { | ||
| return ( | ||
| <div> | ||
| Stake your SYN to receive CX (Cortex Protocol) tokens{' '} | ||
| <a | ||
| href={STAKE_SYN_FOR_CX_URL} | ||
| target="blank" | ||
| className="underline hover:cursor hover:text-white/65" | ||
| > | ||
| here | ||
| </a> | ||
| ! | ||
| </div> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Use _blank and add rel="noopener noreferrer" for external links.
When opening links in a new tab, always ensure to use target="_blank" and rel="noopener noreferrer" to ensure safe navigation.
Apply this diff to fix the target and add rel attributes:
-<a
- href={STAKE_SYN_FOR_CX_URL}
- target="blank"
- className="underline hover:cursor hover:text-white/65"
->
+<a
+ href={STAKE_SYN_FOR_CX_URL}
+ target="_blank"
+ rel="noopener noreferrer"
+ className="underline hover:cursor-pointer hover:text-white/65"
+>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const StakingBannerContent = () => { | |
| return ( | |
| <div> | |
| Stake your SYN to receive CX (Cortex Protocol) tokens{' '} | |
| <a | |
| href={STAKE_SYN_FOR_CX_URL} | |
| target="blank" | |
| className="underline hover:cursor hover:text-white/65" | |
| > | |
| here | |
| </a> | |
| ! | |
| </div> | |
| ) | |
| } | |
| const StakingBannerContent = () => { | |
| return ( | |
| <div> | |
| Stake your SYN to receive CX (Cortex Protocol) tokens{' '} | |
| <a | |
| href={STAKE_SYN_FOR_CX_URL} | |
| target="_blank" | |
| rel="noopener noreferrer" | |
| className="underline hover:cursor-pointer hover:text-white/65" | |
| > | |
| here | |
| </a> | |
| ! | |
| </div> | |
| ) | |
| } |
Bundle ReportChanges will increase total bundle size by 411.09kB (3.33%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
null
4997493: synapse-interface preview link
Summary by CodeRabbit
New Features
Improvements
870eb08: synapse-interface preview link