Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RateLimiter prep for deployment #150

Merged
merged 8 commits into from
May 19, 2022

Conversation

ChiTimesChi
Copy link
Collaborator

@ChiTimesChi ChiTimesChi commented May 19, 2022

Description

  • Removed extra/duplicated openzeppelin repos from package.json.
  • Also deleted duplicated tests.sh Foundry script.
  • RateLimiter is now using 0.8.13 instead of ^0.8.0
  • Added Event + view function for failed retried transaction. This should not happen, unless something is wrong with the tx itself, but would still be nice to have extra control over it.

Checklist

  • New Contracts have been tested
  • Lint has been run
  • I have checked my code and corrected any misspellings

@ChiTimesChi ChiTimesChi requested a review from trajan0x May 19, 2022 17:24
@ChiTimesChi ChiTimesChi changed the title Package.json cleanup RateLimiter prep for deployment May 19, 2022
@coveralls
Copy link

coveralls commented May 19, 2022

Pull Request Test Coverage Report for Build 2353971615

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 37.566%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/bridge/RateLimiter.sol 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
contracts/bridge/SynapseBridge.sol 1 51.32%
Totals Coverage Status
Change from base Build 2348907431: 0.03%
Covered Lines: 813
Relevant Lines: 2043

💛 - Coveralls

@trajan0x trajan0x merged commit c4df2c2 into feature/rate-limiter May 19, 2022
@trajan0x trajan0x deleted the package-json-cleanup-oz branch May 19, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants