-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: SwapQuoterV2
#258
Merged
ChiTimesChi
merged 43 commits into
feat/universal-swap-wrapper
from
feat/new-swap-quoter
Aug 7, 2023
Merged
Feat: SwapQuoterV2
#258
ChiTimesChi
merged 43 commits into
feat/universal-swap-wrapper
from
feat/new-swap-quoter
Aug 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5762213519
💛 - Coveralls |
mikeyrf
reviewed
Aug 1, 2023
mikeyrf
reviewed
Aug 1, 2023
mikeyrf
reviewed
Aug 1, 2023
- `setSynapseRouter()` - `addPools()`
Parity tests where both LinkedPool and SwapQuoterV2 would've caught bug fixed in bd99d2f, therefore added these tests to the TODO list. Shouldn't be too hard, though the old test structure is likely to be these as messy as other parity tests out there. |
mikeyrf
reviewed
Aug 3, 2023
mikeyrf
reviewed
Aug 3, 2023
mikeyrf
reviewed
Aug 3, 2023
021a996
to
d818150
Compare
mikeyrf
reviewed
Aug 3, 2023
@ChiTimesChi outside of a few questions above, looks good to me. |
@mikeyrf the set of tests should be completed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #249. Adds new Quoter contract, which is supposed to keep track of all the supported chain pools. Pools could be either:
In both cases, the pools could be of two types:
IDefaultPool
interface. In other words, these are the pools that Synapse:Bridge currently works with. Allows a single-hop swap between a set of tokens.Quoter returns SynapseRouter-compatible
SwapQuery
structs, which define the swap parameters. See #257 for more details about Router<>Quoter internal interactions.TODO:
SynapseRouter
address to be upgradeable by the contract owner.Checklist