Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entering/leaving fullscreen mode renders error message #48

Closed
dehmer opened this issue Jun 2, 2024 · 1 comment
Closed

Entering/leaving fullscreen mode renders error message #48

dehmer opened this issue Jun 2, 2024 · 1 comment
Assignees
@dehmer
Labels
bug Something isn't working
Milestone
v2.8.1

Comments

@dehmer
Copy link
Member

dehmer commented Jun 2, 2024

When fullscreen mode is changed, main process pops up an error message, but fullscreen mode is changed regardless.
@dehmer dehmer added the bug Something isn't working label Jun 2, 2024
@dehmer dehmer self-assigned this Jun 2, 2024
@dehmer dehmer added this to the v2.8.1 milestone Jun 2, 2024
@dehmer
Copy link
Member Author

dehmer commented Jun 2, 2024

For some reason BrowserWindow events enter-full-screen and leave-full-screen no longer supply a sender: webContents as event data. webContents is used to issue IPC requests to the renderer.

Proposed fix: Use BrowserWindow.webContents directly in event handlers.

dehmer added a commit that referenced this issue Jun 2, 2024
@dehmer
#48 fixed issue with (now) missing event data.
b26b921
ThomasHalwax added a commit that referenced this issue Jun 5, 2024
@ThomasHalwax
Merge pull request #49 from syncpoint/issue/48
9ae152e 
#48 fixed issue with (now) missing event data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dehmer dehmer

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.8.1
Development

No branches or pull requests
2 participants
@dehmer @ThomasHalwax