Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rest: Remove bogus fields from connections API endpoint. #708

Merged
merged 4 commits into from
Jan 10, 2022

Conversation

acolomb
Copy link
Member

@acolomb acolomb commented Jan 9, 2022

Remove fields from the /rest/system/connections element "total" which
are not populated and misleading. Removed in upcoming version.

Remove fields from the /rest/system/connections element "total" which
are not populated and misleading.  Removed in upcoming version.
This reverts commit 76b547e.
Was unintentionally left out in the actual API response.
@acolomb acolomb marked this pull request as ready for review January 9, 2022 22:43
@calmh calmh merged commit 5735ec8 into syncthing:main Jan 10, 2022
@acolomb acolomb deleted the connections-total-empty-fields branch January 10, 2022 09:36
@acolomb
Copy link
Member Author

acolomb commented Jan 10, 2022

So the version info should be correct with v1.19.0? It is technically a change in API, that was my assumption at least.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants