Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage reporting should include Google Play as a distribution channel #9140

Closed
bt90 opened this issue Sep 29, 2023 · 11 comments · Fixed by #9141
Closed

Usage reporting should include Google Play as a distribution channel #9140

bt90 opened this issue Sep 29, 2023 · 11 comments · Fixed by #9141
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion needs-triage New issues needed to be validated

Comments

@bt90
Copy link
Contributor

bt90 commented Sep 29, 2023

Android accounts for 15% of our reported platforms:

image

Google Play is the biggest distribution channel for it, but is completely missing from our stats:

image

@bt90 bt90 added enhancement New features or improvements of some kind, as opposed to a problem (bug) needs-triage New issues needed to be validated labels Sep 29, 2023
@bt90
Copy link
Contributor Author

bt90 commented Sep 29, 2023

I wonder if the Regex is outdated?

{regexp.MustCompile(`android-.*teamcity@build\.syncthing\.net`), "Google Play"},

@bt90
Copy link
Contributor Author

bt90 commented Sep 29, 2023

My app reports builder@github.syncthing.net which would misclassify it as GitHub

@calmh
Copy link
Member

calmh commented Sep 29, 2023

Maybe set the build user to something else for the android build and add an entry accordingly.

@bt90
Copy link
Contributor Author

bt90 commented Sep 29, 2023

Either that or also check the GOOS to determine the channel.

builder@github.syncthing.net + android -> Google Play

@acolomb
Copy link
Member

acolomb commented Sep 29, 2023

But that would be a wrong assumption, no? If one bundles a build from GitHub with the app and distributes it over some other channel, this would be incorrect. I agree that the version extra string is the better way to achieve this.

@bt90
Copy link
Contributor Author

bt90 commented Sep 29, 2023

I was under the impression that the Syncthing library for the wrapper needed some additional treatment, and you can't just bundle our regular arm binary?

@tomasz1986
Copy link
Contributor

tomasz1986 commented Sep 29, 2023

It's the regular binary, just compiled for Android. Syncthing proper doesn't offer Android binaries separately though.

@bt90
Copy link
Contributor Author

bt90 commented Sep 29, 2023

Exactly. The chance of a thirdparty simply copy-pasting one of our prebuilt binaries into a wrapper is zero.

@bt90
Copy link
Contributor Author

bt90 commented Sep 29, 2023

@bt90
Copy link
Contributor Author

bt90 commented Sep 29, 2023

F-Droid is also outdated: vagrant@bullseye

@bt90
Copy link
Contributor Author

bt90 commented Sep 29, 2023

root@buildkitsandbox looks like some kind of Docker environment?

imsodin pushed a commit to syncthing/syncthing-android that referenced this issue Sep 29, 2023
We need a dedicated build user to be able to distinguish the
distribution channel. See
syncthing/syncthing#9140
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Sep 28, 2024
@syncthing syncthing locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion needs-triage New issues needed to be validated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants