-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage reporting should include Google Play as a distribution channel #9140
Comments
I wonder if the Regex is outdated? syncthing/cmd/ursrv/serve/serve.go Line 67 in dcafd6e
|
My app reports |
Maybe set the build user to something else for the android build and add an entry accordingly. |
Either that or also check the GOOS to determine the channel.
|
But that would be a wrong assumption, no? If one bundles a build from GitHub with the app and distributes it over some other channel, this would be incorrect. I agree that the version extra string is the better way to achieve this. |
I was under the impression that the Syncthing library for the wrapper needed some additional treatment, and you can't just bundle our regular arm binary? |
It's the regular binary, just compiled for Android. Syncthing proper doesn't offer Android binaries separately though. |
Exactly. The chance of a thirdparty simply copy-pasting one of our prebuilt binaries into a wrapper is zero. |
F-Droid is also outdated: |
|
We need a dedicated build user to be able to distinguish the distribution channel. See syncthing/syncthing#9140
Android accounts for 15% of our reported platforms:
Google Play is the biggest distribution channel for it, but is completely missing from our stats:
The text was updated successfully, but these errors were encountered: