capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 #14

wking · 2018-02-20T00:16:55Z

The old methods had an internal Load(), which is unnecessary for some use cases. For example, if you're going to drop all capabilities, you don't need to load the current set first. This commit deprecates the old New* functions and adds New*2 functions which do not include the internal Load. Callers who do need the Load will need to call it explicitly after initializing their Capabilities object. Callers who do not need the Load can just add the 2 to the function name and get more efficient/robust behavior.

The old methods had an internal Load(), which is unnecessary for some use cases. For example, if you're going to drop all capabilities, you don't need to load the current set first. This commit deprecates the old New* functions and adds New*2 functions which do not include the internal Load. Callers who do need the Load will need to call it explicitly after initializing their Capabilities object. Callers who do not need the Load can just add the "2" to the function name and get more efficient/robust behavior. The "Deprecated:" paragraph syntax is recommended in [1]: To signal that an identifier should not be used, add a paragraph to its doc comment that begins with "Deprecated:" followed by some information about the deprecation. [1]: https://blog.golang.org/godoc-documenting-go-code

wking · 2018-02-20T00:35:33Z

There is room for further optimization in this direction by adding a LoadType(which CapType) and/or teaching Get() to auto-load the requested type if it hadn't been loaded yet. I've left those off of this commit (folks can always add them later), but I'm happy to add them here if you'd like.

Take advantage of [1] to avoid crashing with: container_linux.go:348: starting container process caused "open /proc/9976/status: no such file or directory" [1]: syndtr/gocapability#14 Signed-off-by: W. Trevor King <wking@tremily.us>

relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

full diff: syndtr/gocapability@db04d3c...d983527 changes included: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Add tcp service for grpc listeners Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Set nofile to 1048576 Closes containerd#3201 Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Fix API forward events for shims Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Add support for required plugins. Signed-off-by: Lantao Liu <lantaol@google.com> * Use $TEST_RUNTIME for cri test. Signed-off-by: Lantao Liu <lantaol@google.com> * Improve shim shutdown logic Shims no longer call `os.Exit` but close the context on shutdown so that events and other resources have hit the `defer`s. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Add dialer for events service Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Rename `hrpc` to `tcpServer` Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * Check task list to avoid unnecessary cleanup. Signed-off-by: Lantao Liu <lantaol@google.com> * Correct import path in services/server package Signed-off-by: Jared Cordasco <jcordasc@coglib.com> * Correct PusherFunc helper to match Pusher intf Signed-off-by: Jared Cordasco <jcordasc@coglib.com> * Requeue events in the shim publisher Signed-off-by: Michael Crosby <crosbymichael@gmail.com> * bump mistifyio/go-zfs f784269be439d704d3dfa1906f45dd848fed2beb - mistifyio/go-zfs#72 Switch to google/uuid - removes the github.com/pborman/uuid dependency Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * Update go-winio in vendor.conf Signed-off-by: Kevin Parsons <kevpar@microsoft.com> * Allow dumping stacks via ETW capture state Signed-off-by: Kevin Parsons <kevpar@microsoft.com> * Access to client's GRPC connection object Signed-off-by: Maksym Pavlenko <makpav@amazon.com> * .mailmap: update Akihiro Suda's email address No affiliation change (NTT). The former email address will continue to be available for the time being. For daily communication, I still prefer to use my gmail.com address. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> * Move to sha-specified test image for nanoserver Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> * Fix error on pull hang in CI Kill the underlying containerd after outputting error. Otherwise CI hangs indefinitely and requires the CI infrastructure to kill the build at the timeout expiration. Signed-off-by: Wei Fu <fuweid89@gmail.com> Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> * Write stack dump to `os.TempDir()` as well Signed-off-by: John Howard <jhoward@microsoft.com> * bump gocapability full diff: syndtr/gocapability@db04d3c...d983527 changes included: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * Update x/crypto to 88737f569e3a9c7ab309cdc09a07fe7fc87233c3 full diff: golang/crypto@4979611...88737f5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * bump containerd/console 0650fd9eeb50bab4fc99dceb9f2e14cf58f36e7f Signed-off-by: Sebastiaan van Stijn <github@gone.nl> * Convert Windows CI to use Microsoft MCR image urls Signed-off-by: Justin Terry (VM) <juterry@microsoft.com> * Don't write dumped stacks to file for ETW capture state Signed-off-by: Kevin Parsons <kevpar@microsoft.com>

relevant changes: - syndtr/gocapability#14 capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 - syndtr/gocapability#16 Fix capHeader.pid type Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

wking force-pushed the new2-no-load branch 2 times, most recently from de16c6c to c9101b3 Compare February 20, 2018 00:19

wking mentioned this pull request Feb 20, 2018

*: Avoid creation panics when 'process' and 'linux' are unset opencontainers/runc#1726

Closed

syndtr merged commit 33e07d3 into syndtr:master Feb 23, 2018

wking mentioned this pull request Feb 23, 2018

Drop in-container /proc requirement? opencontainers/runc#1734

Open

3 tasks

wking deleted the new2-no-load branch February 23, 2018 05:41

thaJeztah mentioned this pull request Mar 28, 2019

Update dependencies opencontainers/runc#2029

Merged

thaJeztah mentioned this pull request Apr 17, 2019

Bump syndtr/gocapability d983527, containerd/console containerd/containerd#3223

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 #14

capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 #14

wking commented Feb 20, 2018

wking commented Feb 20, 2018

capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 #14

capability: Deprecate NewPid and NewFile for NewPid2 and NewFile2 #14

Conversation

wking commented Feb 20, 2018

wking commented Feb 20, 2018