Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leveldb: fix table file leaks when manifest is rotated #409

Merged
merged 1 commit into from
Jul 21, 2022
Merged

leveldb: fix table file leaks when manifest is rotated #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion leveldb/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,12 @@ func (s *session) commit(r *sessionRecord, trivial bool) (err error) {
}
}()

if s.manifest == nil || s.manifest.Size() >= s.o.GetMaxManifestFileSize() {
if s.manifest == nil {
// manifest journal writer not yet created, create one
err = s.newManifest(r, nv)
} else if s.manifest.Size() >= s.o.GetMaxManifestFileSize() {
// pass nil sessionRecord to avoid over-reference table file
err = s.newManifest(nil, nv)
} else {
err = s.flushManifest(r)
}
Expand Down