Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace in Comments (enters) #336

Open
monotkate opened this issue Mar 2, 2016 · 7 comments
Open

Whitespace in Comments (enters) #336

monotkate opened this issue Mar 2, 2016 · 7 comments
Labels

Comments

@monotkate
Copy link
Member

If you submit a comment with enters between lines of text, it eliminates it after it's submitted.

image

image

@monotkate monotkate added the bug label Mar 2, 2016
@monotkate monotkate changed the title Whitespace in Markdown (enters) Whitespace in Comments (enters) Mar 2, 2016
@Mctalian
Copy link
Member

Mctalian commented Mar 2, 2016

That's because comments aren't Markdown enabled. It works fine in
description and updates.
On Mar 2, 2016 5:07 PM, "monotkate" notifications@github.com wrote:

If you submit a comment with enters between lines of text, it eliminates
it after it's submitted.

[image: image]
https://cloud.githubusercontent.com/assets/11742296/13477192/2a71792a-e099-11e5-983d-dc792a8c5d83.png

[image: image]
https://cloud.githubusercontent.com/assets/11742296/13477204/3ca7a844-e099-11e5-829b-d13ebe3eff39.png


Reply to this email directly or view it on GitHub
#336.

@Mctalian
Copy link
Member

Mctalian commented Mar 2, 2016

So, this can become an enhancement request and/or tech spike to enable only
a small subset of Markdown for comments. It might, however, screw up all
other Markdown if it's a global configuration.
On Mar 2, 2016 5:12 PM, "Robert Anderson" r-anderson.9@onu.edu wrote:

That's because comments aren't Markdown enabled. It works fine in
description and updates.
On Mar 2, 2016 5:07 PM, "monotkate" notifications@github.com wrote:

If you submit a comment with enters between lines of text, it eliminates
it after it's submitted.

[image: image]
https://cloud.githubusercontent.com/assets/11742296/13477192/2a71792a-e099-11e5-983d-dc792a8c5d83.png

[image: image]
https://cloud.githubusercontent.com/assets/11742296/13477204/3ca7a844-e099-11e5-829b-d13ebe3eff39.png


Reply to this email directly or view it on GitHub
#336.

@monotkate
Copy link
Member Author

Yeah I know it's not in markdown but that's weird behavior. Other solution would be to return to a submit on enter for comments

@Mctalian
Copy link
Member

Mctalian commented Mar 3, 2016

I agree it's weird. It's a limitation of HTML, unfortunately. I posted in some issue all the ways I know of to get around this sort of thing, I'll see if I can find it. Enabling Markdown was the solution we chose, but I would vote against Markdown on comments because people could use giant headers and make comments super difficult to scroll through.

@Mctalian
Copy link
Member

Mctalian commented Mar 3, 2016

#264 my comment lists the ways I'm aware of working around it. In addition we can try to create a custom markdown directive with limited features. Perhaps just hyperlinks, lists, and newlines to name a few.

@monotkate
Copy link
Member Author

How about submit on enter?

@Mctalian
Copy link
Member

Mctalian commented Mar 3, 2016

Yeah, that's another option. I know when Yammer submits on enter I get pissed though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants