Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lightning): keep original structure of ldk.claimableBalances #1442

Merged
merged 1 commit into from
Dec 29, 2023
Merged

refactor(lightning): keep original structure of ldk.claimableBalances #1442

merged 1 commit into from
Dec 29, 2023

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Dec 19, 2023

Description

  • Updates store to keep original structure of ldk.claimableBalances to be able to filter out by the different types of balances
  • rewrite reduceValue and add unit tests

Linked Issues/Tasks

#1296

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

@pwltr pwltr linked an issue Dec 19, 2023 that may be closed by this pull request
[Feature]: Keep original structure of ldk.claimableBalances to show valid amount in Transfer card #1296
Closed
@coreyphillips coreyphillips merged commit 528db88 into master Dec 29, 2023
4 checks passed
@coreyphillips coreyphillips deleted the refactor/claimable branch December 29, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyphillips coreyphillips coreyphillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Keep original structure of ldk.claimableBalances to show valid amount in Transfer card
2 participants
@pwltr @coreyphillips