Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lightning): ldk pay timeout #1507

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix(lightning): ldk pay timeout #1507

merged 2 commits into from
Jan 18, 2024

Conversation

Jasonvdb
Copy link
Collaborator

@Jasonvdb Jasonvdb commented Jan 18, 2024

Description

  • Includes fix in this PR removing the occasional premature JS timeout when making a LN payment
  • Version bump
  • Include pending LN txs in activity. react-native-ldk keeps history of all pending, success or failed tx attempts so we only need to filter out failed entries.

Linked Issues/Tasks

#1495

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

If a payment actually does time out now the recipient won't still get it.

@limpbrains
Copy link
Collaborator

If pending payments are now a thing, we should show them in UI respectively

@Jasonvdb
Copy link
Collaborator Author

If pending payments are now a thing, we should show them in UI respectively

Requested designs for this

@Jasonvdb Jasonvdb merged commit 2fb4322 into master Jan 18, 2024
4 checks passed
@Jasonvdb Jasonvdb deleted the ln-pay-timeout-fix branch January 18, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants