Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): change sats symbol #1540

Merged
merged 3 commits into from
Feb 8, 2024
Merged

feat(ui): change sats symbol #1540

merged 3 commits into from
Feb 8, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Feb 7, 2024

Description

₿

Notes

Changes sats symbol to ₿ and adds a setting to switch to classic denomination.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-07.at.16.06.54.mp4

@pwltr pwltr requested a review from Jasonvdb February 7, 2024 15:09
@pwltr pwltr merged commit d79acaf into master Feb 8, 2024
3 of 4 checks passed
@pwltr pwltr deleted the feat/satsymbol branch February 8, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limpbrains limpbrains limpbrains approved these changes

@Jasonvdb Jasonvdb Jasonvdb approved these changes

@rbndg rbndg Awaiting requested review from rbndg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwltr @limpbrains @Jasonvdb