Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: channel UI fixes #1609

Merged
merged 4 commits into from
Mar 18, 2024
Merged

fix: channel UI fixes #1609

merged 4 commits into from
Mar 18, 2024

Conversation

pwltr
Copy link
Collaborator

@pwltr pwltr commented Mar 18, 2024

Description

  • Show 'instant payments ready' toast only for first channel
  • Show connection status & name for all channels (orders, CJIT and third-party)
  • Remove openChannelIds store field and add a status and createdAt (for sorting) to channels list

Linked Issues/Tasks

https://app.asana.com/0/0/1204208728352470/1206703239419962/f

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Simulator Screenshot - iPhone 14 - 2024-03-18 at 12 22 45

QA Notes

Open different channels and check the channels UI

@pwltr pwltr requested a review from limpbrains March 18, 2024 12:10
@pwltr pwltr merged commit b481d0c into master Mar 18, 2024
4 checks passed
@pwltr pwltr deleted the fix/channel-fixes branch March 18, 2024 14:48
@pwltr pwltr self-assigned this Mar 19, 2024
@pwltr pwltr added this to the v.1 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants